Hi Roger, I'm fine w/ doing more clean up.
I have normalized @library and reorganized imports in the all touched files. could you please take a look at new webrev: http://cr.openjdk.java.net/~iignatyev/8180890/webrev.01/index.html <http://cr.openjdk.java.net/~iignatyev/8180890/webrev.01/index.html> for you convenience, here is the diff b/w 00 and 01 webrevs: http://cr.openjdk.java.net/~iignatyev/8180890/webrev.00-01/index.html <http://cr.openjdk.java.net/~iignatyev/8180890/webrev.00-01/index.html> Thanks, -- Igor > Roger Riggs Fri May 26 14:29:30 UTC 2017: > Hi Igor, > > It would be nice if all of the @library source lines were the same (not > mixed in the order). > > Since this is a cleanup task, I might be inclined to make the order of > imports consistent > within those tests but that goes beyond the simple goal of the issue. > > +1 > > Roger >> On May 25, 2017, at 6:28 PM, Igor Ignatyev <[email protected]> wrote: >> >> http://cr.openjdk.java.net/~iignatyev//8180890/webrev.00/index.html >>> 41 lines changed: 5 ins; 4 del; 32 mod; >> >> Hi all, >> >> jsr292 testlibrary is used only by java/lang/invoke tests, so there is no >> reason to have this library in common testlibrary, this changeset moves >> jsr292 testlibrary classes from jdk/test/lib/testlibrary to >> jdk/test/java/lang/invoke/common, so they will be closed to the tests which >> use them. >> >> webrev: http://cr.openjdk.java.net/~iignatyev//8180890/webrev.00/index.html >> jbs: https://bugs.openjdk.java.net/browse/JDK-8180890 >> testing: java/lang/invoke >> >> Thanks, >> -- Igor >>
