Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

[Roger Riggs]

Hi Igor,

Looks fine.

Though I am puzzled why the changeset in the webrev is empty.
http://cr.openjdk.java.net/~iignatyev//8180805/webrev.00/jdk10.patch

Thanks, Roger

On 5/30/2017 12:36 PM, Brian Burkhalter wrote:

Hi Igor,

On May 26, 2017, at 11:30 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote:

this changeset introduces jdk.test.lib.RandomFactory in the top level 
testlibrary and updates all but java/time/ tests to use it instead of 
jdk.testlibrary.RandomFactory from the jdk testlibrary.

Code changes look OK provided all tests still run properly. I have not been 
following the test package refactoring however so no comment on that.

due to CODETOOLS-7901987[1], java/time/ tests can't use the top level 
testlibrary, so jdk.testlibrary.RandomFactory hasn't been removed, however it 
has been marked as deprecated and will be removed by JDK-8181118[2] as soon as 
there is promoted jtreg w/ CODETOOLS-7901987 fixed.

Should this be using “@Deprecated(since=“9”, forRemoval=true)” or something 
like that?

Thanks,

Brian