On 5/31/17 4:01 PM, Alan Bateman wrote:
On 31/05/2017 04:57, Amy Lu wrote:

java/nio/channels/AsynchronousChannelGroup/run_any_task.sh

Please review this patch to refactor the shell test to java.

bug: https://bugs.openjdk.java.net/browse/JDK-8181301
webrev: http://cr.openjdk.java.net/~amlu/8181301/webrev.00/
This looks okay to me although I think I would put the test description before the imports in AsExecutor so you don't have to skip over those to see how the test is run. A minor nit is that the JAR file can be "privileged.jar" rather than "Privileged.jar".

-Alan
Thank you Alan!

Webrev updated according to the suggestions:
http://cr.openjdk.java.net/~amlu/8181301/webrev.01

Thanks,
Amy

Reply via email to