Hi Thomas,
one minor comment apart from what Christoph gave, you can combine the
the two explicit assignment statements to one in all three places.
rv = (jlong)sb.st_mtimespec.tv_sec * 1000;
rv += (jlong)sb.st_mtimespec.tv_nsec / 1000000; to rv=
(jlong)sb.st_mtimespec.tv_sec * 1000 +(jlong)sb.st_mtimespec.tv_nsec / 1000000;
Thanks,
Vyom
On Wednesday 31 May 2017 08:59 PM, Thomas Stüfe wrote:
Hi Volker,
Good suggestions! I completely overlooked the ..._n members in stat64
struct. It seems it is even documented:
https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.files/stat.h.htm
new webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8181207-8177809-breaks-AIX-builds/webrev.01/webrev/
..Thomas
On Wed, May 31, 2017 at 10:49 AM, Volker Simonis <[email protected]>
wrote:
Hi Thomas,
as far as I can see, AIX supports both, the st_[a,c,m]time members in
the stat64 structure for seconds and the corresponding
st_[a,c,m]time_n members for nanosecond resolution since at least 5.3.
Can you please use both - there's no reason to discriminate AIX here
:)
Also, can you please change the code such that we have:
#ifdef MACOSX
...
#else
#ifdef AIX
...
#else
...
#endif
#endif
I don't really like using "ifndef XXX" for everything else except XXX.
Thnank you and best regards,
Volker
On Tue, May 30, 2017 at 11:46 AM, Thomas Stüfe <[email protected]>
wrote:
Hi all,
may I have please a review for this tiny change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8181207
webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8181207-
8177809-breaks-AIX-builds/webrev.00/webrev/
This reverts 8177809 for AIX because it leads to build errors on older
AIX
systems. We want to retain the ability to build on older AIX releases.
Thanks, Thomas
