On 6/6/17 12:11 AM, Amy Lu wrote:
Good point!
Please review the updated version:
http://cr.openjdk.java.net/~amlu/8181396/webrev.01
Sorry, I have to withdraw this version. Somehow this does not work on
Windows, the created blah*tmp will not be deleted until the launched
DeleteOnClose (by itself) also exit.
(webrev.00 works fine.)
Thanks,
Amy
Thanks,
Amy
On 6/5/17 10:52 PM, Alan Bateman wrote:
On 05/06/2017 07:54, Amy Lu wrote:
java/nio/file/Files/delete_on_close.sh
Please review this patch to refactor the shell test to java.
bug: https://bugs.openjdk.java.net/browse/JDK-8181396
webrev: http://cr.openjdk.java.net/~amlu/8181396/webrev.00/
I think it's a bit confusing to have both DeleteOnClose and
DeleteOnTerminate, esp. when DeleteOnTerminate creates a file with
DELETE_ON_CLOSE. Instead couldn't DeleteOnClose just launch itself to
create the file?
-Alan
