Hi Jon, if tests are supposed to declare all library classes they depend on, tests start to depend on a library design, so refactoring of the library will force us to do massive update of the tests to fix their explicit builds, but to find all such tests, we will have to run them one by one. so this approach does not really scale and it is also kinda fragile. if we can not relay on implicit compilation done by @build (and implicit @build) actions, shouldn't we remove it completely? or at least introduce a jtreg flag which disables it or reports all such usage as errors? this will give us a way to find all tests to fix and eventually will make the whole testsuite more reliable.
-- Igor > On Jun 5, 2017, at 3:39 PM, Jonathan Gibbons <[email protected]> > wrote: > > > > On 06/05/2017 03:24 PM, Martin Buchholz wrote: >> Can we find missing @build directives by running each individual jtreg test >> by itself with a clean JTwork directory? > > That's generally been the recommended way. > > You might also be able to do run groups of tests (such as all tests that use > a given library) and then look for duplicate classes in the compiled classes > directory. Such classes will generally be an indication of implicit > compilation. > > -- Jon
