On 06/06/2017 06:10, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8181335/webrev.00/index.html
I added this so-called "packageless" CompilerUtils some time ago. I see
the version copied into the top-level repo is an older version and
doesn't specify UOE or handle the JRE case. Can you update the version
in the top repo as part of this so that they are the same?
A minor annoyance with this change is that it makes the line lengths
inconsistent in a number of tests -- e.g.
Class/forName/modules/TestDriver.java now has a 100+ line which should
be split into two to avoid horizontal scrolling.
Also can you explain what the difference is between /lib/testlibrary and
/test/lib? Maybe this is just work in process?
Finally, one thing to keep in mind is that you are changing tests and
test infrastructure that is still changing in jdk9/dev. We have one (we
hope) final module system refresh coming that changes several of the
tests that you are changing. This might be a bit annoying for whoever
sync's up jdk10/jdk10 from jdk9/jdk9 in a few weeks time.
-Alan.
