Hi Paul,

Please check my comments inline below.


On 2017/6/14 1:23, Paul Sandoz wrote:
On 12 Jun 2017, at 20:37, Hamlin Li <huaming...@oracle.com> wrote:

Hi Paul,

Good idea. Although the downside is the test will depend on java.management and 
jdk.management modules, I think it's acceptable.

Although to Roger’s point is there a simpler way?
No. Please also check my response to Roger.
Also disable to run ParallelPrefix.java in concurrency.

Ok.
Please check the new webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.01/

   29  * @run testng/othervm -Xms256m -Xmx1024m ParallelPrefix

Why are you setting the max heap size?
In my test result, 1024M is sufficient, and if I don't set it, I'm not sure what's the default value for it, so set it explicitly for this memory sensitive test.
Please let me know if you think it's unnecessary.

Thank you
-Hamlin

Paul.


Reply via email to