Minor stuff below, no need for another round from me.
Paul.
CharsetProviderBasicTest
—
85 public static Iterator<Object[]> testCases() {
86 List<Object[]> cases = new ArrayList<>();
87 Stream.of("", "ja_JP.eucJP", "tr_TR")
88 .forEach(locale -> {
89 cases.add(new Object[]{locale, List.of(""), "FOO"});
90 cases.add(new Object[]{locale, MINIMAL_POLICY, "!FOO"});
91 cases.add(new Object[]{locale, CP_POLICY, "FOO"});
92 });
93 return cases.iterator();
More for educational purposes. You can use flatMap(l ->
Stream.of(…)).iterator() rather than using a list to hold the contents.
117 if (!locale.equals("")) {
if (!locale.isEmpty())) {
> On 18 Jun 2017, at 23:09, Amy Lu <[email protected]> wrote:
>
> java/nio/charset/spi/basic.sh
>
> Please review this patch to refactor the shell test to java.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8181575
> webrev: http://cr.openjdk.java.net/~amlu/8181575/webrev.00/
>
> Thanks,
> Amy
