Hi, I've pushed to JDK10 now: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/7a2bc0a80087
What do you think, shall we try to downport a fix to JDK9 updates and JDK8 updates, which simply removes the volatile as we can't bring this behavior changing fix down? Thanks Christoph > -----Original Message----- > From: Kazunori Ogata [mailto:oga...@jp.ibm.com] > Sent: Freitag, 30. Juni 2017 20:31 > To: Seán Coffey <sean.cof...@oracle.com> > Cc: Langer, Christoph <christoph.lan...@sap.com>; core-libs-dev <core-libs- > d...@openjdk.java.net>; nio-...@openjdk.java.net; ppc-aix-port- > d...@openjdk.java.net > Subject: Re: 8182743: Ineffective use of volatile hurts performance of > Charset.atBugLevel() > > Hi Sean, > > Thank you for your comments. > > I fixed the copyright and updated webrev: > > http://cr.openjdk.java.net/~horii/8182743/webrev.03/ > > > > * The bug ID referenced in mail/webrev links is wrong. It should be > > 8182743 ? > > Yes, they should be 8182743. I fixed both. > > > Regards, > Ogata > > > Seán Coffey <sean.cof...@oracle.com> wrote on 2017/06/30 23:57:25: > > > From: Seán Coffey <sean.cof...@oracle.com> > > To: Kazunori Ogata <oga...@jp.ibm.com>, "Langer, Christoph" > > <christoph.lan...@sap.com> > > Cc: "ppc-aix-port-...@openjdk.java.net" <ppc-aix-port- > > d...@openjdk.java.net>, core-libs-dev <core-libs-dev@openjdk.java.net>, > > "nio-...@openjdk.java.net" <nio-...@openjdk.java.net> > > Date: 2017/06/30 23:57 > > Subject: Re: 8179527:(8182743?) Ineffective use of volatile hurts > > performance of Charset.atBugLevel() > > > > Ogata, > > > > minor comments from me. > > > > * The bug ID referenced in mail/webrev links is wrong. It should be > > 8182743 ? > > * The copyright change in Charset-X-Coder.java.template is the wrong > > format. You can simply replace 2013 with 2017. > > > > Regards, > > Sean. > > > > On 29/06/17 19:49, Kazunori Ogata wrote: > > > Hi Christoph, > > > > > > I updated webrev: > http://cr.openjdk.java.net/~horii/8179527/webrev.02/ > > > > > > This one includes changes in tests. I removed all @run and @build > > > directives in the tests because those after removing "@run > main/othervm > > > -Dsun.nio.cs.bugLevel=1.4 EmptyCharsetName" are the same as the > default > > > ones. I checked the modified tests passed. > > > > > > I also fixed the copyright lines. > > > > > > > > > Regards, > > > Ogata > > > > > > > > > "Langer, Christoph" <christoph.lan...@sap.com> wrote on 2017/06/28 > > > 21:04:36: > > > > > >> From: "Langer, Christoph" <christoph.lan...@sap.com> > > >> To: Kazunori Ogata <oga...@jp.ibm.com> > > >> Cc: Alan Bateman <alan.bate...@oracle.com>, Claes Redestad > > >> <claes.redes...@oracle.com>, core-libs-dev <core-libs- > > >> d...@openjdk.java.net>, "nio-...@openjdk.java.net" <nio- > > >> d...@openjdk.java.net>, "ppc-aix-port-...@openjdk.java.net" > > > <ppc-aix-port- > > >> d...@openjdk.java.net> > > >> Date: 2017/06/28 21:04 > > >> Subject: RE: 8179527: Ineffective use of volatile hurts performance > of > > >> Charset.atBugLevel() > > >> > > >> Hi Ogata, > > >> > > >>>> remove the second run with -Dsun.nio.cs.bugLevel=1.4 > > >>> How can I do this? Is it sufficient to remove the following line at > > > the > > >>> beginning of the file?: "@run main/othervm -Dsun.nio.cs.bugLevel=1.4 > > >>> EmptyCharsetName" > > >> Yes, this line should be removed. Currently there are two @run > > > directives > > >> which cause running the testcase twice. Once in normal mode and once > > > with > > >> bugLevel set to 1.4. So, if "sun.nio.cs.bugLevel" ought to be removed > > > then > > >> the second iteration of the test is obsolete. And then one should > > > probably > > >> remove the whole "compat" handling in the test. > > >> > > >> Best regards > > >> Christoph > > >> > > > > > >
