Hi Christoph, thanks for your review.
On Wed, Jul 5, 2017 at 11:33 AM, Langer, Christoph <christoph.lan...@sap.com> wrote: > Hi Volker, > > overall, the change looks good to me. > > When you create the Exception to print the stack trace (line 129 in the new > file), why not add the value of 'java.vm.info' to the message? Good point. I'll do so. > Also, I don't like the spaces around the '.' before PrintStackTrace() - but > maybe that's just my personal taste. ;-) You're right. I somehow thought that the spaces are the default "coding style" for OpenJDK but I've checked and you're right that by default we don't use spaces when calling a method right on a 'new' expression. I'll update the change accordingly. Regards, Volker > > Best regards > Christoph > >> -----Original Message----- >> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On >> Behalf Of Volker Simonis >> Sent: Dienstag, 4. Juli 2017 11:05 >> To: HotSpot Open Source Developers <hotspot-...@openjdk.java.net>; >> Java Core Libs <core-libs-dev@openjdk.java.net> >> Subject: [10] RFR(XS): 8183534: [TEST] Make detection of compilation mode >> more robust >> >> Hi, >> >> can you please review the following trivial change which makes the >> detection of compilation mode for JTreg more robust: >> >> http://cr.openjdk.java.net/~simonis/webrevs/2017/8183534/ >> https://bugs.openjdk.java.net/browse/JDK-8183534 >> >> The compilation mode in JTreg is parsed from the "java.vm.info" system >> property. The current implementation expects that "java.vm.info" >> contains exactly one of the strings "mixed mode", "compiled mode" or >> "interpreted mode" otherwise the detection will fail and JTreg will >> quit with an error. >> >> The detection can be done more robust by searching for the substrings >> "mixed mode", "compiled mode" or "interpreted mode" instead, thus >> allowing OpenJDK builders to store additional information in the >> "java.vm.info" system property. >> >> Thank you and best regards, >> Volker
