Hi Amy,looks fine. Just one comment on sentence below. "LOCALE" looks to be a local variable, though used several times. Switch to usual naming?
50 final String LOCALE = args[2]; -Felix On 2017/7/6 9:47, Amy Lu wrote:
java/lang/System/MacEncoding/MacJNUEncoding.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8183378 webrev: http://cr.openjdk.java.net/~amlu/8183378/webrev.00/ Thanks, Amy
