> On Jul 14, 2017, at 4:26 PM, Weijun Wang <weijun.w...@oracle.com> wrote: > > >> On Jul 14, 2017, at 4:23 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Jul 13, 2017, at 5:14 PM, Amy Lu <amy...@oracle.com> wrote: >>> >>> java/lang/ClassLoader/deadlock/TestCrossDelegate.sh >>> java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh >>> >>> Please review this patch to refactor the shell tests to java. >>> >>> bug: https://bugs.openjdk.java.net/browse/JDK-8183377 >>> http://cr.openjdk.java.net/~amlu/8183377/webrev.00/ >> >> I suggest to use the scratch directory instead of user.dir so that the files >> will be cleaned up. > > I haven’t reviewed the code but aren’t scratch and ${user.dir} the same thing?
Good catch. I mis-read it as “user.home”. Then that part is okay. I think compiling the other classes to a destination explicitly to replace: 29 * @build Alice Bob SupAlice SupBob 30 * @run driver SetupLoader will make the test clearer. It’d be good to make that change. Mandy
