Thanks, Mandy I’ve updated patch http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/ <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/>
—Andrei > On 25 Jul 2017, at 16:12, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Jul 21, 2017, at 6:35 PM, Andrey Nazarov <andrey.x.naza...@oracle.com> >> wrote: >> >> Hi, >> >> Please review changes in launcher tests. I’ve added absent @modules jtreg >> tags. >> >> Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ >> <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/> > > A few tests only require java.compiler but not jdk.compiler. Maybe > TestHelper should be updated to use java.util.spi.ToolProvider to find > “javac” to avoid the dependency to java.compiler if no compiler is needed. > > test/tools/launcher/modules/upgrademodulepath/UpgradeModulePathTest.java > - can you keep @modules list in alphabetical order. > > Mandy
