Hi Jon,
looks good,
Advertising
While you are in DateTimeFormatter.java can you add a leading '
(single-quote) to the example for
ISO_WEEK_DATE in the Predefiend Formatters table. Line 246.
Thanks, Roger
On 8/11/2017 4:59 PM, Jonathan Gibbons wrote:
On 08/11/2017 01:32 PM, Lance Andersen wrote:
Hi Jon
On Aug 11, 2017, at 3:10 PM, Jonathan Gibbons
<jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>>
wrote:
Lance,
I was in two minds about changing the layout of the columns in
RoundingMode.
It can sometimes hard to discern the intent of the author. In
addition, numbers
can be problematic because ideally you want the overall column of
numbers to
"centered", but each individual number to be right-aligned within
that centered area
-- and that is not easily expressible. The best that we've achieved
elsewhere is to use
"right-aligned, with some right padding". While that can be done,
the local
style declarations start overwhelming the content ... and the whole
trend of
HTML5 and CSS is to separate content and style.
In this case, there are several tables that would benefit from a
specific style
declaration, but it's not important enough IMO to add to the main
javadoc stylesheet.
But, the javadoc team is working on enhancements to the use of
stylesheets,
and maybe that will give a better way forward, eventually.
But I agree the left-aligned values look less than ideal. The
question is, do you
want to add one of the following to all the appropriate cells:
style="text-align:center"
style="text-align:right; padding-right=Nem" // for some value of N
I am happy to give it a go after your initial putback and see out it
looks
I looked at the page again. The values are already all right-aligned,
so it would just be a case of adding padding.
I think the displayed HTML would look nice, but the source HTML would
be less so. It's a shame, since it would
be easy to do in either page-specific CSS or in a stylesheet.
-- Jon
Best
Lance
-- Jon
On 08/11/2017 11:44 AM, Lance Andersen wrote:
Hi Jon,
Looks OK overall
Any thoughts on centering some of the column values such as in
RoundingMode at some point?
DateTimeFormatter looks much nicer :-)
Best
Lance
On Aug 11, 2017, at 2:28 PM, Jonathan Gibbons
<jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>>
wrote:
Please review the following changes to fix accessibility and HTML
issues in the
java.math, java.text and java.time packages.
Mostly, it's "more of the same", setting scope=row|col on tables.
One bigger change is in DateTimeFormatter, to change a
preformatted ASCII
table into a standard HTML table.
JBS: https://bugs.openjdk.java.net/browse/JDK-8186153
Webrev: http://cr.openjdk.java.net/~jjg/8186153/webrev.00/
<http://cr.openjdk.java.net/%7Ejjg/8186153/webrev.00/>
API: http://cr.openjdk.java.net/~jjg/8186153/api.00/
<http://cr.openjdk.java.net/%7Ejjg/8186153/api.00/>
-- Jon
<Mail Attachment.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
