On 31/08/2017 08:27, Thomas Stüfe wrote:
Hi all,
may I please have reviews for the following patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8186665
Webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8186665-buffer-overflow-in-mincore/webrev.00/webrev/
The oversizing of the vec array (to ensure that you don't pass an
undersized array to mincore) might not be immediately obvious to
maintainers in the future. So it would be good to add a comment on that.
A minor nit is that the library code uses 4 (not 2) indentation.
Otherwise looks okay to me.
-Alan
