Hi Joe, Overall looks good.
As we discussed, I would add a comment to NameNodeMapImpl.java read/writeObject describing the use of Vector for backward compatibility. No need for another webrev :-) Best Lance > On Oct 12, 2017, at 2:24 PM, Joe Wang <[email protected]> wrote: > > Hi, > > Please review a cleanup of rawtypes and unchecked warnings from JAXP sources. > > The patch involved a good number of classes (278). However, the majority of > the changes are straight-forward replacement, e.g. s/Vector/List[ArrayList] > and their relevant methods e.g. s/elementAt/get and etc. In a few cases, > ArrayIndexOutOfBoundsException was substituted with IndexOutOfBoundsException > as they were caught. > > A few cleanups unrelated to rawtypes and unchecked were made before Roger's > suggestion to stay within the scope of the request, that is, a couple of > StringBuffer substitution, other than that this changeset is almost rawtypes > and unchecked cleanup only. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8181150 > webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8181150/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
