Looks good.
Thanks, Roger
On 10/18/17 6:11 PM, mandy chung wrote:
On 10/18/17 5:18 PM, Roger Riggs wrote:
Hi Mandy,
typo in BasicTest: line 50: "200 the parameter" - "200 parameter"
Fixed.
I think I would have had the tests exactly fit the slots of 200 and 201.
The test exceeds the limit by 2 possibly hiding an off by 1 error.
Arrays.fill(types, 100, 102, int.class);
Thanks. I caught that later myself.
Updated:
http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8187089/webrev.01/
Mandy
Roger
On 10/18/17 4:32 PM, mandy chung wrote:
StringConcatFactory::makeConcat and makeConcatWithConstants APIs are
specified to accept concatType to have a maximum of 200 parameter
slots.
If violated, it should throw StringConcatException. The implementation
mistakenly checks the parameter count. The javadoc of these methods
states "parameter count" rather than "parameter slots" whereas
@apiNote in the class spec correctly says "parameter slots".
Webrev:
http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8187089/webrev.00/
CSR:
https://bugs.openjdk.java.net/browse/JDK-8189634
Thanks
Mandy
