That's fine. Thanks
On 10/30/2017 3:17 PM, Joe Wang wrote:
On 10/30/17, 11:14 AM, Roger Riggs wrote:
Hi Joe,
+1
Is there a useful comment on the @SuppressWarnings like in other files:
XSDHandler.java: 3028
DTMDocumentImpl: 1700
DOM2DTM.java: 1654
FilterExprWalker.java: 65
For the methods with long or very long switch statements, I added a
note following the SuppressWarnings annotation to indicate where
fallthrough would happen and in which case warnings were suppressed.
But for the pretty short ones like the above, I thought it's quite
obvious where fallthrough might happen, I didn't therefore add any
comment.
A few of the added breaks would have been hiding bugs.
It might be worth mentioning them in the issue.
I added a note to the issue.
Thanks,
Joe
