Hi Jack, Overall looks OK. I am assuming all of the test suites are passing?
Best Lance > On Nov 2, 2017, at 7:34 AM, Lance Andersen <[email protected]> wrote: > > Hi Jack > > Its on my list to finish by the end of the week. > > Best > Lance >> On Nov 2, 2017, at 4:34 AM, Jack Li <[email protected]> wrote: >> >> Hi Lance >> >> Is there anything wrong in the new webrev? >> >> >>> On Oct 25, 2017, at 10:00, Jack Li <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Hi Lance, >>> >>> The webrev is updated, can you please review it again? >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 >>> <https://bugs.openjdk.java.net/browse/JDK-8187954> >>> Webrev: >>> http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 >>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01> >>> >>> Summary of changes: >>> >>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/* >>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module >>> >>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/** >>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to >>> avoid crash after javac change >>> And also contains the fixes for importing nodes for SOAPDocumentFragment >>> >>> >>> Patch also contains several small bugfixes, not tracked in JBS. >>> >>>> On Oct 11, 2017, at 18:47, Lance Andersen <[email protected] >>>> <mailto:[email protected]>> wrote: >>>> >>>> Hi Jack, >>>> >>>> I would prefer to see an updated webrev so that we do not inadvertently >>>> push these changes. >>>> >>>> Best >>>> Lance >>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[email protected] >>>>> <mailto:[email protected]>> wrote: >>>>> >>>>> Hi Lance >>>>> >>>>> I will update them in Metro repository, do I need to regenerate webrev? >>>>> or can you skip the files this time and I fix it in next integration? >>>>> >>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[email protected] >>>>>> <mailto:[email protected]>> wrote: >>>>>> >>>>>> Hi Jack, >>>>>> >>>>>> UnMarshaller also has the same issue. I would update the webrev given >>>>>> the number of places to help sanity check for omissions >>>>>> >>>>>> Best >>>>>> Lance >>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[email protected] >>>>>>> <mailto:[email protected]>> wrote: >>>>>>> >>>>>>> Hi Lance, >>>>>>> >>>>>>> the change is incorrect, it should be “javax/xml/bind”. >>>>>>> thanks a lot for your finding, do you think I need to fix it and >>>>>>> resubmit the webrev this time? >>>>>>> or can you skip this file this time and I fix it in next integration? >>>>>>> >>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[email protected] >>>>>>>> <mailto:[email protected]>> wrote: >>>>>>>> >>>>>>>> Hi Jack, >>>>>>>> >>>>>>>> Is this change correct: >>>>>>>> >>>>>>>> ------------- >>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java >>>>>>>> 2017-09-29 13:58:31.968185273 +0100 >>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java >>>>>>>> 2017-09-29 13:58:31.676185267 +0100 >>>>>>>> @@ -373,7 +373,7 @@ >>>>>>>> * If the {@link ValidationEventHandler >>>>>>>> ValidationEventHandler} >>>>>>>> * returns false from its {@code handleEvent} method or the >>>>>>>> * {@code Marshaller} is unable to marshal {@code >>>>>>>> jaxbElement} (or any >>>>>>>> - * object reachable from {@code jaxbElement}). See <a >>>>>>>> href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling"> >>>>>>>> + * object reachable from {@code jaxbElement}). See <a >>>>>>>> href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling"> >>>>>>>> * Marshalling a JAXB element</a>. >>>>>>>> >>>>>>>> ------------ >>>>>>>> >>>>>>>> The URL that is being changed currently works >>>>>>>> >>>>>>>> Best >>>>>>>> Lance >>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[email protected] >>>>>>>> <mailto:[email protected]>> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. >>>>>>>>> >>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 >>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8187954> >>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8187954 >>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8187954>> >>>>>>>>> Webrev: >>>>>>>>> http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ >>>>>>>>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> >>>>>>>>> >>>>>>>>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ >>>>>>>>> >>>>>>>>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>> >>>>>>>>> >>>>>>>>> Summary of changes: >>>>>>>>> >>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/* >>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind >>>>>>>>> module >>>>>>>>> >>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/** >>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be >>>>>>>>> modified to avoid crash after javac change >>>>>>>>> And also contains the fixes for importing nodes for >>>>>>>>> SOAPDocumentFragment >>>>>>>>> >>>>>>>>> >>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS. >>>>>>>>> >>>>>>>>> ---------------- >>>>>>>>> Best regards >>>>>>>>> Jack Li >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> <oracle_sig_logo.gif> >>>>>>>> >>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >>>>>>>> Oracle Java Engineering >>>>>>>> 1 Network Drive >>>>>>>> Burlington, MA 01803 >>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>[email protected] >>>>>>>> <mailto:[email protected]> >>>>>>> >>>>>>> ---------------- >>>>>>> Best regards >>>>>>> Jack Li >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> <oracle_sig_logo.gif> >>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >>>>>> Principal Member of Technical Staff | +1.781.442.2037 >>>>>> Oracle Java Engineering >>>>>> 1 Network Drive >>>>>> Burlington, MA 01803 >>>>>> [email protected] <mailto:[email protected]> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> ---------------- >>>>> Best regards >>>>> Jack Li >>>> >>>> <oracle_sig_logo.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >>>> Principal Member of Technical Staff | +1.781.442.2037 >>>> Oracle Java Engineering >>>> 1 Network Drive >>>> Burlington, MA 01803 >>>> [email protected] <mailto:[email protected]> >>>> >>>> >>>> >>> >>> >>> ---------------- >>> Best regards >>> Jack Li >>> >>> >>> >>> >>> >>> >> >> >> ---------------- >> Best regards >> Jack Li >> >> >> >> >> >> > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > [email protected] <mailto:[email protected]> > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
