Hi Mandy,
A few editorial suggestions:
MethodHandle.java:
891: "accepts**a** zero-length trailing array argument
895: "if **the* *{@code array} does"
MethodHandleImpl.java:
667: hard to follow indentation; perhaps adding the "else" will help.
MethodHandles.java:
2517: "Produces a method handle *for* constructing arrays..."
2523: "array size, *a* {@code NegativeArraySizeException} will be thrown."
2550: "array reference, *a* {@code NullPointerPointer} exception will be
thrown."
2573 & 2598 & 2641: "*A* {@code NullPointerPointer} *exception* will be
thrown if the array reference
Is there a test for asSpreader(null, 0) and asSpreader(null, 1)? (The
new exception thrown at MethodHandleImpl:667)
Roger
On 11/8/2017 1:20 PM, Paul Sandoz wrote:
On 8 Nov 2017, at 10:13, mandy chung <mandy.ch...@oracle.com> wrote:
On 11/8/17 8:49 AM, Paul Sandoz wrote:
On 7 Nov 2017, at 12:06, mandy chung <mandy.ch...@oracle.com>
<mailto:mandy.ch...@oracle.com> wrote:
http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8157246/webrev.00/index.html
<http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8157246/webrev.00/index.html>
This fixes the spec of MethodHandles::arrayLength, arrayConstructor,
arrayElementGetter/Setter to specify the behavior if the returned method handle
is invoked with null array or invalid index; same runtime exception thrown by
the bytecode behavior. MethodHandle::asSpreader spec is also clarified to
throw NPE and IAE except when it spreads with no argument and the returned
method handle accepts a zero-length array or null array.
Looks good, minor comment.
MethodHandle
--
889 * When the adapter is called, the length of the supplied {@code
array}
890 * argument is queried as if by {@code array.length} or {@code
arrayLength}
s/arrayLength/arraylength/
See also MethodHandles.
Oops typo. Fixed.
http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8157246/webrev.01/
<http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8157246/webrev.01/>
Here is the CSR:
https://bugs.openjdk.java.net/browse/JDK-8190945
<https://bugs.openjdk.java.net/browse/JDK-8190945>
Can you also review it?
Reviewed.
Paul.
