Finally did some review with Alan and integrated all into this webrev: http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.01 <http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.01>
-Patrick > Am 08.11.2017 um 00:03 schrieb Brian Burkhalter <brian.burkhal...@oracle.com>: > > Hi Patrick, > > On Nov 7, 2017, at 3:01 PM, Patrick Reinhart <patr...@reini.net > <mailto:patr...@reini.net>> wrote: > >> I integrated your changes into my current version which I will look into >> tomorrow with Alan at Devoxx. I think adding some implementation note on the >> default method implementation will be needed to review later on… > > I concur. > >> I also made an override on the CharBuffer, where we need to add a enhanced >> documentation for the specialties around the CharBuffer implementations >> (BufferOverflowException/ReadOnlyBufferException), where a review of some >> native english speakers would help :-) > > Sounds good! > > Thanks, > > Brian
