> On Dec 1, 2017, at 5:17 PM, Mandy Chung <[email protected]> wrote: > > >>> On Dec 1, 2017, at 4:46 PM, Brent Christian <[email protected]> >>> wrote: >>> >>> On 12/1/17 11:40 AM, Brent Christian wrote: >>> On 12/1/17 8:33 AM, mandy chung wrote: >>>>> Better still might be for initSystemClassLoader to re-throw the cause so >>>>> that it appears immediately after the "Error occurred during >>>>> initialization of VM" message that the VM will fail with. >>>> >>>> Yes that would be better. >>> So would I do this for RuntimeException and Error, and then package checked >>> types of causes in an Error, as Mandy suggested? (We don't want to throw a >>> checked exception from initSystemClassLoader(), I don't think.) >> >> Anyway, this is what that looks like (I did RuntimeException, but didn't >> bother with Error). I also made the test changes that Mandy suggested. >> >> http://cr.openjdk.java.net/~bchristi/8187222/webrev.01/index.html >> > > Yes and I think should also rethrow the cause if the cause is an Error (why > not)
The instanceof RuntimeException check should be moved outside to the if-statement when it’s an instance of InvocationTargetException. Mandy
