On 12/14/17, 9:58 AM, Vladimir Kozlov wrote:
On 12/13/17 6:52 PM, David Holmes wrote:
Hi Sherman,
On 14/12/2017 12:05 PM, Xueming Shen wrote:
David, Martin,
webrev has been updated to fix the test directly.
http://cr.openjdk.java.net/~sherman/8193479/webrev
That seems to me to be invalidating the whole point of the test,
which was a regression test for 6896617 to check that the
optimizations put in place actually get applied. ??
But I'll leave that up to the compiler guys to decide.
Assume I would need hotspot guys' help to review and push into hs repo?
You'll need to fix in both jdk/hs and jdk/jdk as the breakage is now
in both. Fix one and import to the other.
But I still suggest adding the test to ProblemList.txt now so that
this isn't broken in JDK 10 fork, then fix the actual test at a more
leisurely pace in jdk/hs.
I agree with David. Lets exclude it for now and fix it later properly
without rush.
Thanks
Vladimir
Thanks Vladimir,
I have a webrev out there. But I will probably have to wait for the
new jdk10 repo open next week.
Or maybe the hs repo is still open for something like this? and
you guys can help get it in directly there?
Sherman
--------------------------------------------
It appears the consensus is to put this one into the ProblemList and let
the
hotspot folks to fix the test case.
issue: https://bugs.openjdk.java.net/browse/JDK-8193479
webrev: http://cr.openjdk.java.net/~sherman/8193479/webrev
The corresponding hotspot/compiler issue filed: JDK-8193549.
Thanks,
Sherman
----------------------------------------------
