Hi Joe,
Overall, this is fine, a few things to consider if you want to address
Happy Holidays
Best
Lance
Do we really need to keep the name in comments such as these:
final class TestSeq {
---
old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java
2017-12-21 11:04:12.188400062 -0800
+++
new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java
2017-12-21 11:04:11.423325345 -0800
@@ -682,7 +682,7 @@
// If the new name has a different prefix, the list may
become unsorted.
// Maybe it would be better to resort the list, but the
simplest
// fix seems to be to remove the old attribute and
re-insert it.
- // -- [email protected], 2 Feb 2007
+ // -- Norman Walsh, 2 Feb 2007
Do we need Sun Microsystems, Inc as we are not consistent
---
old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java
2017-12-21 11:05:03.519413044 -0800
+++
new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java
2017-12-21 11:05:02.758338717 -0800
@@ -40,7 +40,7 @@
* calling NamespaceSupport methods.
*
* @author Neeraj Bajaj, Sun Microsystems, inc.
- * @author [email protected]
+ * @author Santiago PericasGeertsen
*
*/
public class LocationImpl implements Location{
String systemId;
---
old/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java
2017-12-21 11:05:31.112107741 -0800
+++
new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java
2017-12-21 11:05:30.352033512 -0800
@@ -32,7 +32,7 @@
import javax.xml.XMLConstants;
/**
*
- * @author Neeraj Bajaj,[email protected] Sun Microsystems.
+ * @author Neeraj Bajaj,K Venugopal Sun Microsystems.
*/
> On Dec 21, 2017, at 2:23 PM, Joe Wang <[email protected]> wrote:
>
> http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html
> <http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
