Hi,
I got the test results and I also manually tested on Windows,
everything looks good, you can go ahead and push the changes.
Thanks
Kumar
The last time around, I was missing the deploy repo and thus the
build/test system did not take deploy into account. My error.
I will retest and report.
Kumar
Hi,
I can not do proper tests with OracleJDK, sorry for that.
This webrev removes the problem from the ProblemList:
http://cr.openjdk.java.net/~goetz/wr18/8195824-fixHelpTest2/webrev.02/
Actually, you should have an internal ProblemList for things
that fail with the OracleJDK. We do so for SAP JVM and our OpenJDK
builds, too.
Best regards,
Goetz.
-----Original Message-----
From: David Holmes [mailto:david.hol...@oracle.com]
Sent: Dienstag, 23. Januar 2018 08:50
To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; core-libs-dev
<core-
libs-...@openjdk.java.net>
Subject: Re: RFR(XS): 8195824: tools/launcher/HelpFlagsTest.java
fails with
java.lang.AssertionError
Hi Goetz,
On 23/01/2018 5:36 PM, Lindenmaier, Goetz wrote:
Hi,
javacpl seems not to have a help message, so it just needs to
be excluded from the test. Please review.
http://cr.openjdk.java.net/~goetz/wr18/8195824-fixHelpTest2/webrev/
That seems okay. Did you test it on Windows? Also ...
(I sent similar mail in reply to RE: JDK 11 RFR of
JDK-8195987,,Problem list
tools/launcher/HelpFlagsTest.java fails on windows)
... the ProblemList change was pushed so will have to be reverted by
this change.
Has this test now been tested on all platforms with both the OpenJDK
and
OracleJDK?
Thanks,
David
Best regards,
Goetz.
