Hi, Please review the revised webrev at http://cr.openjdk.java.net/~sdama/8011697/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8011697
Regards, Srinivas -----Original Message----- From: Alan Bateman Sent: Monday, December 11, 2017 10:05 PM To: Srinivas Dama <srinivas.d...@oracle.com>; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one) On 11/12/2017 15:26, Srinivas Dama wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8011697/webrev.00/ > for https://bugs.openjdk.java.net/browse/JDK-8011697 > > Fix is to make sure ScriptEngineManager always returns a particular engine on > all platforms consistently. > I assume using a TreeSet would work too. A different approach is replace engineSpis with nameToFactory and extensionToFactory maps so that the getEngineByXXX methods don't need to a sequential search. -Alan
