On 03/02/2018 2:36 AM, mandy chung wrote:


On 2/2/18 7:02 AM, Amy Lu wrote:
Please review the patch to move some tests to OpenJDK for jdk_lang test group.

bug: https://bugs.openjdk.java.net/browse/JDK-8195981
webrev: http://cr.openjdk.java.net/~amlu/8195981/webrev.00/


I suggest to merge jdk/vm/misc and jdk/vm/monitor directory and
rename to jdk/vm/runtime which avoids "misc" a dumping group
and is explicit that this directory is for runtime-related tests.
JITClassInit.java seems a JIT related test and maybe moved it
to jdk/vm/jit.

ExceptionInInit.java
    Can you reformat the comment block line 59-95 where some lines
should be merged into the line above.

Thank you Mandy for reviewing. Pushed with changes as suggested.


Bug4404588.java can be renamed to reflect what this test does.
What about renaming it to
java/lang/Character/UnicodeBlock/SpecialsUnicodeBlock.java?

Forgot this one. Will do in separate bugid later.

Thanks,
Amy


Otherwise, looks okay.

Mandy

Reply via email to