Hi Chris,

Looks fine.

These are only positive tests, are there negative tests planned?

Thanks, Roger

On 1/23/2018 5:14 AM, Chris Yin wrote:
Thank you Alan, I just moved it to com/sun/jndi/dns/ as you suggested and removed 
unused "@modules jdk.naming.dns/com.sun.jndi.dns”, updated webrev as below, 



On 23 Jan 2018, at 3:53 PM, Alan Bateman <alan.bate...@oracle.com> wrote:

On 23/01/2018 07:01, Chris Yin wrote:
Please review the added JNDI test javax/naming/dns/AttributeTests/GetAny.java, 

You may want to move it to com/sun/jndi/dns so that it's with the other tests for the DNS 
provider (as there is no javax.naming.dns API). Also I suspect you don't need 
"@modules jdk.naming.dns/com.sun.jndi.dns" as it doesn't appear to make direct 
use of the classes in the implementation.


Reply via email to