Hi Chris,

I don't know DNS details well enough to validate the test assertions.
Otherwise, the code is fine.

Regards, Roger


On 2/5/2018 3:15 AM, Chris Yin wrote:
Please review the added JNDI test 
com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java, thanks

It’s to verify capability to add a new entry to the directory using the ADD 
operation. This test will use LDAPServer to playback dump ldap message to 
simulate test environment.

bug: https://bugs.openjdk.java.net/browse/JDK-8196770
webrev: http://cr.openjdk.java.net/~xiaofeya/8196770/webrev.00/

Regards
Chris

Reply via email to