Looks good to me too.

Would you want to update the Copyright year? For the apache file (ToStream.java), it would also be good to update the @LastModified tag.


Thanks,
Joe

On 2/23/2018 12:33 PM, Roger Riggs wrote:
There are two more changes in the java.xml package. (Thanks Joe)
Webrev updated in place.

http://cr.openjdk.java.net/~rriggs/webrev-line-separator-8198645/

Thanks, Roger

On 2/23/2018 2:50 PM, Xueming Shen wrote:
+1

On 02/23/2018 11:39 AM, Roger Riggs wrote:
Please review cleanup replacements of System.getProperty("line.separator") with System.lineSeparator(). It uses the line separator from System instead of looking it up in the properties each time.
Also fixed one javadoc @see reference.

The affected files are in several packages:

   com/sun/crypto/provider/
   java/util/regex/
   jdk/internal/util/xml/impl/

Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-line-separator-8198645/

Thanks, Roger





Reply via email to