Thanks Alan, Roger!
Less is better. Removed the ones that take FileDescriptors, now we're
only adding Constructors that take String+Charset and File+Charset.
Tests are updated accordingly. Build/Test may take a while, but expected
to pass since it was simply removing the FileDescriptor from the Enum.
JBS: https://bugs.openjdk.java.net/browse/JDK-8183554
webrev: http://cr.openjdk.java.net/~joehw/jdk11/8183554/webrev/
Best,
Joe
On 3/5/2018 1:10 PM, Roger Riggs wrote:
Hi Joe,
For files by name and File these are useful additions. The new
constructors with
FileDescriptors don't have a strong use case for them and re-using
file descriptors
is something that developers need to be more careful about. They
don't need the
added convenience constructors and can build readers and writers from
streams
when they need it.
Regards, Roger
On 3/5/2018 2:25 PM, Joe Wang wrote:
Hi,
Adding constructors with a Charset parameter for FileReader and
FileWriter. Please review.
JBS: https://bugs.openjdk.java.net/browse/JDK-8183554
webrev: http://cr.openjdk.java.net/~joehw/jdk11/8183554/webrev/
Thanks,
Joe
