I applied those changes here: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.02
-Patrick > Am 06.03.2018 um 23:12 schrieb Brian Burkhalter <[email protected]>: > > Yes, I think so and and also the parameter ‘csq' is allowed to be null so > Objects.requireNonNull(csq) should be removed at lines 100 and 107 as no NPE > is specified for these methods [1, 2]. > > Thanks, > > Brian > > [1] > https://download.java.net/java/jdk10/docs/api/java/io/Writer.html#append(java.lang.CharSequence) > [2] > https://download.java.net/java/jdk10/docs/api/java/io/Writer.html#append(java.lang.CharSequence,int,int) > > On Mar 6, 2018, at 11:49 AM, Bernd Eckenfels <[email protected]> wrote: > >> Just a nit, Should append(CharSequence,int,int) also use checkFromIndexSize? >
