Looks ok to me.
Apart from the -source 1.9 -target 1.9 issue Paul already brought up, my
only
concern is that the multiplicity of variants makes running this test
somewhat time
consuming[1]. Complete test coverage is important, so to cut down on
testing
overheads then maybe it's time to examine if we can let go of some of
the optional
variants (BC_SB_SIZED, MH_SB_SIZED, ...)?
/Claes
[1] ~45s on linux-x64, ~1m40s on linux-x64-debug
On 2018-03-26 09:45, Aleksey Shipilev wrote:
Paul S. had reviewed, any other reviewers need/want to review?
Thanks,
-Aleksey
On 03/22/2018 06:56 PM, Aleksey Shipilev wrote:
Bug:
https://bugs.openjdk.java.net/browse/JDK-8200118
Webrev:
http://cr.openjdk.java.net/~shade/8200118/webrev.01/
This adds the relevant test to StringConcat family of tests, which asserts all
strategies do the
right thing. There was a bug in MH_* strategies caused by the already fixed bug
in filterArguments
[1], which this test was supposed to find, if existed before.
Testing: run-test with jdk/jdk, run-test before/after filterArguments fix in
jdk-updates/jdk10u
Thanks,
-Aleksey
[1] https://bugs.openjdk.java.net/browse/JDK-8194554
