On Tue, Mar 27, 2018 at 9:24 AM, Xueming Shen <xueming.s...@oracle.com> wrote:
> >> 8200124: Various cleanups in jar/zip >> http://cr.openjdk.java.net/~martin/webrevs/jdk/zip-cleanup/ < >> http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/zip-cleanup/> >> https://bugs.openjdk.java.net/browse/JDK-8200124 >> > > don't see any change in ZipCoder.java though. > > Whitespace only. > > >> This one I'm not too sure about: >> The public fields of StandardCharsets are part of the public API, so they >> definitely need to exist. So let's create them directly (i.e. using "new", >> not Charset.forName) and don't bother putting these fields anywhere else. >> >> Motivation: I ran into trouble using reflection via >> StandardCharsets.<clinit> too early during bootstrap with a local mod. >> >> 00000000: Avoid charset lookup machinery in StandardCharsets >> http://cr.openjdk.java.net/~martin/webrevs/jdk/StandardCharsets/ < >> http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/StandardCharsets/> >> > OK, this now has a real bug: 8200310: Avoid charset lookup machinery in java.nio.charset.StandardCharsets http://cr.openjdk.java.net/~martin/webrevs/jdk/StandardCharsets/ https://bugs.openjdk.java.net/browse/JDK-8200310
