On 10/04/2018 20:03, Andrey Nazarov wrote:

On 10 Apr 2018, at 11:47, Alan Bateman <alan.bate...@oracle.com> wrote:

On 10/04/2018 19:44, Andrey Nazarov wrote:
Anyone?

On 6 Apr 2018, at 17:10, Andrey Nazarov <andrey.x.naza...@oracle.com> wrote:

Hi,

Please review fix in Jlink test. The fix is to close the Stream which works 
with a file system.

Review: http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01 
<http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01>
JBS: https://bugs.openjdk.java.net/browse/JDK-8178867

If you want, you can get rid of temporary javaFiles list and use 
.forEach(args::add) instead.
Yes. It looks cleaner. 
http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.03
I agree with Paul that it would be nice to replace new ArrayList<>(List.of("-d", ... )) too but what you have is okay.

-Alan

Reply via email to