Ok, thanks. When the CSR is approved please directly send me an exported changeset and i will push for you.
Paul. > On Apr 12, 2018, at 5:49 AM, Vivek Theeyarath <vivek.theeyar...@oracle.com> > wrote: > > Hi, > I have updated the doc as per the suggestion. Have finalized the csr > too. > > Regards > Vivek > -----Original Message----- > From: Paul Sandoz > Sent: Thursday, April 12, 2018 12:40 AM > To: Vivek Theeyarath <vivek.theeyar...@oracle.com> > Cc: Roger Riggs <roger.ri...@oracle.com>; Core-Libs-Dev > <core-libs-dev@openjdk.java.net> > Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate > > HI, > > Hopefully this is the last update :-) > > To align with asPredicate and Roger’s prior guidance on that method i think > you can just say this: > > Creates a predicate that tests if this pattern matches a given input string. > > which is similar to the language of Pattern.matches. > > No need for another webrev if this change is acceptable. > > Paul.