Hi Robert, Thanks. The addition of mismatch is reasonable. I am unsure about compareToUnsigned, since we are trying to be a conservative about what we add to Buffer.
I’ll take a closer look but it may take a little while to get around to it. Would you mind logging a web bug and attaching your patch? The bug will get triaged and make its way to me, then i won’t forget and you can track it. Thanks, Paul. > On Apr 23, 2018, at 7:23 AM, Robert Stupp <sn...@snazy.de> wrote: > > The proposed patch is an improvement for Byte/Short/Int/LongBuffer classes to > add compareToUnsigned() that works like compareTo() but treats the values as > unsigned to leverage the vectorized mismatch implementations, which are not > publicly accessible. > > In addition to that, it adds mismatch() for all *Buffer classes. > > Both new methods basically expose all the goodness of > jdk.internal.util.ArraysSupport to *Buffer. > > The patch includes adoptions to the existing unit tests as well. > > Robert > > -- > Robert Stupp > @snazy > > <buffer-unsigned-mismatch.txt>
