Hi Bernd,
Thanks for the review. Please refer to the next email in this thread,
I've changed it to read a chunk at a time instead.
Best,
Joe
On 4/27/2018 2:32 AM, Bernd Eckenfels wrote:
If this really stays this way and reads all bytes into memory it should at
least state so, as this can easily overflow heap. Besides the Javadoc is pretty
specific but fails to mention the size comparison.
Greetings
Bernd
Gruss
Bernd
--
http://bernd.eckenfels.net
________________________________
From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> on behalf of Joe Wang
<huizhe.w...@oracle.com>
Sent: Friday, April 27, 2018 6:51:08 AM
To: nio-dev; core-libs-dev
Subject: RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file
contents
Hi,
Considering extending isSameFile to add isSameContent to Files. Please
review.
JBS: https://bugs.openjdk.java.net/browse/JDK-8202285
webrev: http://cr.openjdk.java.net/~joehw/jdk11/8202285/webrev/
specdiff:
http://cr.openjdk.java.net/~joehw/jdk11/8202285/specdiff/java/nio/file/Files.html
Thanks,
Joe
