Re: RFR: 8177276: MethodHandles.insertArguments doesn't specify IllegalArgumentException on index mismatch

[mandy chung]

+1

Mandy

On 5/22/18 6:00 PM, Vivek Theeyarath wrote:

Thanks for the comments Mandy. I have updated the test accordingly.

http://cr.openjdk.java.net/~vtheeyarath/8177276/webrev.04/ <http://cr.openjdk.java.net/%7Evtheeyarath/8177276/webrev.04/>

Regards

Vivek

*From:*mandy chung
*Sent:* Tuesday, May 22, 2018 10:07 PM

*To:* Vivek Theeyarath <vivek.theeyar...@oracle.com>; Paul Sandoz <paul.san...@oracle.com> *Cc:* core-libs-dev <core-libs-dev@openjdk.java.net>; Nadeesh TV <nadeesh.thatathil.vala...@mdcpartners.be> *Subject:* Re: RFR: 8177276: MethodHandles.insertArguments doesn't specify IllegalArgumentException on index mismatch

On 5/22/18 9:09 AM, Vivek Theeyarath wrote:

    Hi All,

       Thanks for the comments. I have incorporated the changes as per 
Nadeesh's and Paul's comments. The test runs fine with jtreg post the changes. 
Also, the typo errors Mandy pointed out has also been fixed. Please find the 
updated webrev.

    http://cr.openjdk.java.net/~vtheeyarath/8177276/webrev.03/

<http://cr.openjdk.java.net/%7Evtheeyarath/8177276/webrev.03/>

Looks fine.   Nit:  line 119-133 in MethodHandlesInsertArgumentsTest.java can be converted into two  @Test(expected = ClassCastException.class) cases like the other two IAE cases.  You can update it before you push.

Mandy