Hi Stuart, The changes look fine. Is there a CSR or a release note that also needs to be reviewed?
Best Lance > On Jun 1, 2018, at 5:16 PM, Stuart Marks <stuart.ma...@oracle.com> wrote: > > Hi all, > > Please review this changeset to remove the Thread.destroy() and > Thread.stop(Throwable) methods. Both of these methods have been deprecated > for a long time, and they were deprecated for removal in Java SE 9. > > Thread.destroy() was never implemented, and has always thrown > NoSuchMethodError back to the caller. Thread.stop(Throwable) was made > non-functional in JDK 8, throwing UnsupportedOperationException back to the > caller. > > Note that the no-arg Thread.stop() method remains deprecated, not for > removal, and is unaffected by this changeset. > > Note also that ThreadGroup.destroy() doesn't actually destroy any threads -- > just thread groups -- and that it is also unaffected by this changeset. > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8204243 > > Webrev: > > http://cr.openjdk.java.net/~smarks/reviews/8204243/webrev.0/ > > Thanks, > > s'marks > aka @DrDeprecator <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
