On 04/06/2018 20:59, Roger Riggs wrote:
Hi Alan,
Updated webrev in place:
http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709/
The splitting of the note into @apiNote and @implNote mostly looks good.
I think it should be "cached by the Java virtual machine" rather than
"cached internally". It would be good to fix inconsistent line length
while you are there.
I still think we need to find a better name for SystemProperty and it
would be good to re-visit how this is initialized in initPhase1. I think
this is Stuart's point too. It would be nice to call it with "props" so
that it captures the initial value of the interesting properties. A
second best would be to a SystemProperties.capture() or something explicit.
There's something not quite right with the change to SocksSocketImpl
that I mentioned in the other mail.
-Alan
