On 07/06/2018 13:03, Baesken, Matthias wrote:
Hi Christoph you are correct I compiled it on the wrong platforms , stupid
mistake !
Will send an updated web rev .
* Also, mapFileName can't be used at this place, because it has already
been free'ed there.
Yes, makes sense. Will move the free-calls .
Please make sure you run some manual tests also to ensure the message
looks correct. Not sure if you really need mapFileName to be printed -
it's generally a static file within java.home
regards,
Sean.
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 7. Juni 2018 13:52
To: Baesken, Matthias <[email protected]>; [email protected]
Cc: Lindenmaier, Goetz <[email protected]>
Subject: RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]
Hi Matthias,
in line 527, where the actual output is done, I think you would need to replace
variable 'message' with 'outputMessage', otherwise I guess it won't compile??
Also, mapFileName can't be used at this place, because it has already been
free'ed there.
But in general the additions make sense and will make it easier to find issues
in the tzmappings file.
Best regards
Christoph
From: Baesken, Matthias
Sent: Donnerstag, 7. Juni 2018 13:35
To: [email protected]<mailto:[email protected]>
Cc: Langer, Christoph <[email protected]<mailto:[email protected]>>;
Lindenmaier, Goetz <[email protected]<mailto:[email protected]>>
Subject: [RFR] 8204539: improve error messages in matchJavaTZ [windows]
Hi, could you please review this small change that improves the error
messages in matchJavaTZ .
A reason of the failure is added to the message , and also the offset where
the error happened .
Bug :
https://bugs.openjdk.java.net/browse/JDK-8204539
Webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8204539/
Thanks, Matthias
