Thank you Paul for the review. >I am guessing the comment selectively disables the warning in this code >(rather than using a diagnostic pragma). yes
I have updated the patch on latest repo changes. http://cr.openjdk.java.net/~sdama/8196988/webrev.02/ pushing the above changeset. Note: I have run mach5 tests successfully. Regards, Srinivas ----- Original Message ----- From: paul.san...@oracle.com To: srinivas.d...@oracle.com Cc: core-libs-dev@openjdk.java.net, james.las...@oracle.com Sent: Tuesday, 12 June, 2018 10:08:53 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi Subject: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Looks ok. Including Jim in case he is not listening in… I am guessing the comment selectively disables the warning in this code (rather than using a diagnostic pragma). Thanks, Paul. > On Jun 7, 2018, at 11:17 PM, Srinivas Dama <srinivas.d...@oracle.com> wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8196988/webrev.01/ > for https://bugs.openjdk.java.net/browse/JDK-8196988 > > > Note: Modified earlier fix to handle warning messages specific to > libjimage only. > > Regards, > Srinivas > > ----- Original Message ----- > From: srinivas.d...@oracle.com > To: core-libs-dev@openjdk.java.net > Sent: Monday, 4 June, 2018 11:08:08 PM GMT +05:30 Chennai, Kolkata, Mumbai, > New Delhi > Subject: RFR: 8196988 (Resolve disabled warnings for implicit-fallthrough gcc > option) > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8196988/webrev.00/ > for https://bugs.openjdk.java.net/browse/JDK-8196988 > > Note: gcc 7.3 compiler emits warnings for implicit fall-through switch > cases,but > these warnings are disabled earlier.I have enabled these warnings and fixed > in sources. > > Regards, > Srinivas
