looks good to me.
Vyom
On Friday 29 June 2018 06:22 AM, Chris Yin wrote:
Hi, Vyom
Sure, fixed the tag order as you suggested, thanks
New changes:
diff -r 1308189b0848 test/jdk/com/sun/jndi/dns/Test6991580.java
--- a/test/jdk/com/sun/jndi/dns/Test6991580.javaThu Jun 28 17:45:59
2018 -0700
+++ b/test/jdk/com/sun/jndi/dns/Test6991580.javaFri Jun 29 08:48:05
2018 +0800
@@ -33,10 +33,11 @@
/*
* @test
* @bug 6991580 8080108 8133035
- * @requires os.family != "windows"
* @summary IPv6 Nameservers in resolv.conf throws NumberFormatException
* @modules java.desktop
* jdk.naming.dns/com.sun.jndi.dns
+ * @requires os.family != "windows"
+ * @build IPv6NameserverPlatformParsingTest
* @run main/manual Test6991580
*/
Regards,
Chris
On 28 Jun 2018, at 7:02 PM, vyom tewari <vyom.tew...@oracle.com
<mailto:vyom.tew...@oracle.com>> wrote:
Hi Chris,
change looks good to me. My NetBeans always complains about tag order
if it is not correct, as you adding the new tag i will suggest you
to please fix the tag order as well.
/*
* @test
* @bug 6991580 8080108 8133035
* @summary IPv6 Nameservers in resolv.conf throws NumberFormatException
* @modules java.desktop
* jdk.naming.dns/com.sun.jndi.dns
* @requires os.family != "windows"
* @build IPv6NameserverPlatformParsingTest
* @run main/manual Test6991580
*/
Thanks,
Vyom
On Thursday 28 June 2018 07:31 AM, Chris Yin wrote:
Please review below one line change for manual test case
com/sun/jndi/dns/Test6991580.java to build test class automatically
which will be used in manual steps, thanks
bug: https://bugs.openjdk.java.net/browse/JDK-8187069
Review change as below:
diff -r 2d3e99a72541 test/jdk/com/sun/jndi/dns/Test6991580.java
--- a/test/jdk/com/sun/jndi/dns/Test6991580.javaWed Jun 27 17:02:41
2018 -0700
+++ b/test/jdk/com/sun/jndi/dns/Test6991580.javaThu Jun 28 09:50:37
2018 +0800
@@ -37,6 +37,7 @@
* @summary IPv6 Nameservers in resolv.conf throws
NumberFormatException
* @modules java.desktop
* jdk.naming.dns/com.sun.jndi.dns
+ * @build IPv6NameserverPlatformParsingTest
* @run main/manual Test6991580
*/
Regards,
Chris
