Hi Srinivas,
If runTests() throws exception then "System.gc()" will not be invoked.
Thanks,
Vyom
On Monday 23 July 2018 07:46 PM, Srinivas Dama wrote:
Hi Alan,
As discussed in private conversations, I am pushing below fix for the issue.
webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.04/
Bug: https://bugs.openjdk.java.net/browse/JDK-8206445
Ran all mach5 tests successfully.
Regards,
Srinivas
----- Original Message -----
From: [email protected]
To: [email protected], [email protected]
Sent: Monday, 9 July, 2018 4:23:48 PM GMT +05:30 Chennai, Kolkata, Mumbai, New
Delhi
Subject: Re: [11] RFR: 8206445: JImageListTest.java failed in Windows
On 09/07/2018 11:38, Srinivas Dama wrote:
Hi,
Please review
webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8206445
testListEmptyFile looks okay but you can reduce the code if if you use
Path.of("."). testListNotAnImage can use Path.of(".") too. Also it can
use Files.writeString which will avoid the test trying to list the
contents of the image while the file is open.
Will you make sure to test this on all platforms before pushing? These
tests have been on and off the exclude list several times in the last
week and it would be good to check that this one is stable before it
runs again.
-Alan
