Hi, On 2018-08-23 17:12, Remi Forax wrote:
Hi Claes,useCanonPrefixCache = useCanonCaches ? getBooleanProperty("sun.io.useCanonPrefixCache",false) : false; can be written useCanonPrefixCache = useCanonCaches && getBooleanProperty("sun.io.useCanonPrefixCache",false);
sure.
and the name useCanonCaches/useCanonPrefixCache should follow the coding convention USE_CANON_CACHES/USE_CANON_PREFIX_CACHE.
While agreeable, I think there's also value that the constants reflect the property names used to set them, while renaming the properties feels far out of scope. I'll opt not to rename anything, unless you insist.
/Claes
