On Tue, Aug 28, 2018 at 2:26 AM Brian Burkhalter <brian.burkhal...@oracle.com> wrote: > > Hi Volker, > > On Aug 27, 2018, at 6:53 AM, Volker Simonis <volker.simo...@gmail.com> wrote: > > sorry, I'm a little late in the game. I've just looked at your change > and in general it looks good! > > > Thanks: better late than never! > > There's one thing however I think you still have to fix. After > changing 'stat64' to 'stat' in UnixFileSystem_md.c you should define > 'stat' to 'stat64' on AIX if you don't want to change the current > behavior: > > $ hg diff > diff -r 8455a2fda5a8 src/java.base/unix/native/libjava/UnixFileSystem_md.c > --- a/src/java.base/unix/native/libjava/UnixFileSystem_md.c Mon > Aug 27 11:30:50 2018 +0200 > +++ b/src/java.base/unix/native/libjava/UnixFileSystem_md.c Mon > Aug 27 14:55:07 2018 +0200 > @@ -59,6 +59,7 @@ > #define opendir opendir64 > #define readdir readdir64 > #define closedir closedir64 > + #define stat stat64 > #endif > > #if defined(__solaris__) && !defined(NAME_MAX) > > > Thanks for pointing that out. An updated webrev with this change is at > > http://cr.openjdk.java.net/~bpb/8207744/webrev.05/ > > The build and first tests with this addition look good. I'll also put > the fix into our nightly queue to run some more extensive tests and > let you know the results tomorrow. > > > I ran this revision through our test system and there were no failures on the > platforms we usually test. If your tests succeed then this should be good to > go unless there are objections. >
Our internal testing was successful as well. Ready to push! Regards, Volker > Thanks, > > Brian
