Hi Naoto,

The spec for clone doesn't say whether the clone should share or not share the TimeZone.
Did you consider that if sharedZone was true , *not* to clone the TimeZone?
It would still get cloned when requested from getTimeZone().

This does seem somewhat safer not to change the cloning behavior but I don't think the behavior would be observable.

The current code and test is fine, except for reducing the potential for sharing the TimeZone.

Thanks, Roger

On 9/4/2018 2:14 PM, Naoto Sato wrote:
Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8210142

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8210142/webrev.00/

The fix is a simple one line change, which is to make the sharedZone field consistent with the cloned TimeZone instance in Calendar.clone().

Naoto

Reply via email to