On 07/09/2018 08:41, Xueming Shen wrote:
:
We currently don't have a auto-regression test with corresponding
machine_locale
setup/configuration for this one, Pallavi.Sonal kindly helped to
verified it manually
on his local setup (see attached). It would be desired to have a
specific testing
configuration to catch such error going forward, but it would be
better done
separately.
This change looks fine, and easy to miss because it was specific to the
FNF exception.
Yes, we do need to do something to help catch issues like this easier,
esp. Japanese and Chinese versions of Windows where we've had several
issues over the years. I think we'll need a test that uses a range of
exceptions from different areas to make sure that we've got all these
code paths.
-Alan
